Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds user export job creation. #112

Merged
merged 3 commits into from Oct 5, 2018
Merged

Conversation

dmark
Copy link
Contributor

@dmark dmark commented Jun 28, 2018

Adds the users-exports endpoint to the SDK for user database export job creation.

@codecov-io
Copy link

codecov-io commented Jun 28, 2018

Codecov Report

Merging #112 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   93.47%   93.49%   +0.02%     
==========================================
  Files          32       32              
  Lines         644      646       +2     
==========================================
+ Hits          602      604       +2     
  Misses         42       42
Impacted Files Coverage Δ
auth0/v3/management/jobs.py 85.71% <100%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a2831...46885e6. Read the comment docs.

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

@dmark
Copy link
Contributor Author

dmark commented Jul 13, 2018

Added a test. Complete newb wrt Mock, but I think I got it right.

@lbalmaceda
Copy link
Contributor

Yes, it looks fine 👌 Thanks!

@lbalmaceda lbalmaceda added this to the v3-Next milestone Jul 13, 2018
@lbalmaceda lbalmaceda merged commit 0dc145a into auth0:master Oct 5, 2018
@dmark dmark deleted the jobs-users-exports branch October 5, 2018 20:11
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.4.0 Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants